added comma format like 04/2/2014, 03:00:37#156
Open
BrianLeishman wants to merge 1 commit intoaraddon:masterfrom
Open
added comma format like 04/2/2014, 03:00:37#156BrianLeishman wants to merge 1 commit intoaraddon:masterfrom
04/2/2014, 03:00:37#156BrianLeishman wants to merge 1 commit intoaraddon:masterfrom
Conversation
klondikedragon
added a commit
to itlightning/dateparse
that referenced
this pull request
Dec 15, 2023
Incorporate PR araddon#156 from https://github.com/BrianLeishman and adapt to also validate the format
iTanken
added a commit
to godoes/dateparse
that referenced
this pull request
Apr 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added comma support and tests for this format:
04/02/2014, 04:08:09
4/2/2014, 04:08:09
04/02/2014, 04:08 AM
04/02/2014, 04:08 PM
If I use luxon's
date.toLocaleString(luxon.DateTime.DATETIME_SHORT)on my machine, the formats with the AM/PM are used, and that comma was breaking things.Also fixed an error on the line
_, err := p.parse()where the new err on this line was shadowing the return err, causing it and the err on further down the function to never get returned.